Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return 404 for S3 PermanentRedirect exceptions #365

Merged
merged 2 commits into from
May 28, 2024
Merged

Return 404 for S3 PermanentRedirect exceptions #365

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4aea69f
catch s3 permanentredirect error
jreadey May 25, 2024
203b734
catch s3 redirect for put_object
jreadey May 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions hsds/util/s3Client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ async def get_object(self, key, bucket=None, offset=0, length=-1):
msg = f"s3_key: {bucket}/{key} not found "
log.info(msg)
raise HTTPNotFound()
elif response_code == "NoSuchBucket":
elif response_code in ("NoSuchBucket", "PermanentRedirect"):
msg = f"s3_bucket: {bucket} not found"
log.info(msg)
raise HTTPNotFound()
Expand Down Expand Up @@ -374,7 +374,7 @@ async def put_object(self, key, data, bucket=None):
}
except ClientError as ce:
response_code = ce.response["Error"]["Code"]
if response_code == "NoSuchBucket":
if response_code in ("NoSuchBucket", "PermanentRedirect"):
msg = f"s3_bucket: {bucket} not found"
log.warn(msg)
raise HTTPNotFound()
Expand Down
Loading