Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 409 Conflict in domain test on Windows #354

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

mattjala
Copy link
Contributor

@mattjala mattjala commented Apr 22, 2024

testCreateDomainNodeIds sometimes gets an HTTPConflict trying to create its domain. This is because the domain helpers generate a domain name based on the current timestamp and the given domain name. Both this test and testCreateDomain use the same given domain name of newdomain.h6, and because of Windows' low time resolution, sometimes both domains are created at the same timestamp and have a name conflict.

This PR changes the name of the domain in testCreateDomainNodeIds to avoid the conflict regardless of timestamp.

Resolves #353

@mattjala mattjala added bug ci/cd Issues related to the CI/CD setup and execution labels Apr 22, 2024
@mattjala mattjala requested a review from jreadey April 22, 2024 15:31
@mattjala mattjala self-assigned this Apr 22, 2024
@jreadey
Copy link
Member

jreadey commented Apr 29, 2024

Curious - why did this only crop up on Windows?

@mattjala
Copy link
Contributor Author

Curious - why did this only crop up on Windows?

The root issue is the same as with most of the other Windows issues recently: time.time() only has a resolution of about 16ms, so it's not uncommon for two objects to be created within the same <16 ms period of time and be given the exact same timestamp.

@mattjala mattjala merged commit 9dea6ec into HDFGroup:master Apr 29, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci/cd Issues related to the CI/CD setup and execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

409 Conflict during testCreateDomainNodeIds
3 participants