-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix timestamp inaccuracy during domain scan #349
Conversation
Is it still possible to get stuck in a loop for system without a precise time.time()? |
I don't think so - it hasn't cropped up on a Windows test runner yet. |
This would be a slightly separate issue, but depending on inter-node timestamp accuracy for scans is a fragility issue in general. Would it be wise to modify the DN to respond to scan requests with 202 (Accepted) and 102 (In Progress) until the scan is complete? This would require users doing scans to re-poll a provided endpoint, so it'd be a breaking API change, but it would make scans more robust and might eliminate similar issues in the future. |
If it's not causing a problem in the test runners, I'd leave the scan request stuff as is for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
getNow()
introduces inter-node inaccuracies which lead to issue #348 on POSIX systems. If it's available with precision,time.time()
is better, so we use that instead.Resolves #348.