Fix inaccurate creation order on Windows #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreadey
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
This looks good.
Potentially there is still an issue comparing timestamps set by different nodes (say the creation time of two different datasets). If they are instantiated on different DNs then there's no guarantee the time values correlate with the actions of the client. But since this only comes up in link creation comparisons where the links are on a single object it should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows,
time.time()has a low resolution (~16ms), so objects created in sequence sometimes have the same 'created' timestamp.Creation time is now computed by adding the precise time elapsed since node startup (from
time.perf_counter) to the recorded unix time at node startup, in the new helpertimeUtil.getNow().Fixes #344