Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return internal server error on failed hyperslab write #342

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

mattjala
Copy link
Contributor

@mattjala mattjala commented Apr 9, 2024

  • Remove testPutVLenUTF8, since the case it was testing (sequence of variable-length strings) isn't supported by HSDS.
  • _doHyperslabWrite now causes the client to receive an internal server error if it fails, instead of silently failing and still returning 200.

@mattjala mattjala added the bug label Apr 9, 2024
@mattjala mattjala self-assigned this Apr 9, 2024
jreadey
jreadey previously approved these changes Apr 15, 2024
Copy link
Member

@jreadey jreadey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattjala
Copy link
Contributor Author

Test should be restored and renamed to make it clear it's just checking that HSDS doesn't crash

@mattjala mattjala marked this pull request as draft April 15, 2024 21:57
@mattjala mattjala force-pushed the error_on_failed_slab_write branch from e45c835 to f58d933 Compare April 16, 2024 15:23
@mattjala mattjala marked this pull request as ready for review April 16, 2024 15:25
Copy link
Member

@jreadey jreadey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@jreadey jreadey merged commit 5c24172 into HDFGroup:master Apr 17, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants