Add support for "where in" queries #327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjala
reviewed
Mar 18, 2024
| log.warn("Unexpected error in guess_chunk size") | ||
|
|
||
| # stop iteration if we haven't increased the chunk size | ||
| log.debug("stopping epandChunk iteration") |
There was a problem hiding this comment.
epandChunk -> expandChunk
mattjala
reviewed
Mar 18, 2024
| if not where_elements: | ||
| msg = "query: where key word with no elements" | ||
| raise ValueError(msg) | ||
| # convert to ndarray, checking than we can convert to our dtype along the way |
There was a problem hiding this comment.
than we can convert -> that we can convert
mattjala
reviewed
Mar 18, 2024
| if where_field: | ||
| # return array based on where in elements | ||
| log.debug("query - no eval_str, returning where in array") | ||
| return chunk_arr |
There was a problem hiding this comment.
chunk_sel seems to be the result of the selection from a where in query - should that be returned here instead?
mattjala
reviewed
Mar 18, 2024
| @@ -0,0 +1,4 @@ | |||
| sphinx==5.0.0 | |||
| sphinx_rtd_theme==1.0.0 | |||
| readthedocs-sphinx-search==0.1.1 | |||
There was a problem hiding this comment.
Version for readthedocs-sphinx-search should be bumped to at least 0.3.2 to resolve the security issue
mattjala
reviewed
Mar 18, 2024
| Request Authentication | ||
| ---------------------- | ||
|
|
||
| The HSDS REST supports HTTP Basic authentication to authenticate users |
There was a problem hiding this comment.
HSDS REST -> HSDS REST API
mattjala
reviewed
Mar 18, 2024
| within a password file. Alternatively, Bearer authentication can be used | ||
| where a security token is issued by a provider such as Active Directory. | ||
| In either case, once the request is authenticated a requestor username | ||
| will be determine (unless anonymous request are supported, in which case |
mattjala
reviewed
Mar 18, 2024
| header) requests on the domain would be granted or denied as follows | ||
|
|
||
| - GET /datasets/<id> - granted (returns HTTP Status 200 - OK) | ||
| - POST /datasets/<id>/value - granted (returns HTTP Status 200 - OK) |
There was a problem hiding this comment.
Maybe add a clarification here that this operation is a point/hyperslab read
There was a problem hiding this comment.
Actually, I think this should be POST /datasets if it's supposed to represent creation permissions
mattjala
reviewed
Mar 18, 2024
| - GET /datasets/<id> - granted (returns HTTP Status 200 - OK) | ||
| - POST /datasets/<id>/value - granted (returns HTTP Status 200 - OK) | ||
| - PUT /datasets/<id>/shape) - grant (returns HTTP Status 200 - OK) | ||
| - PUT /datasets/<id>/attributes/<name> - denied (returns HTTP Status |
There was a problem hiding this comment.
PUT and DELETE here should be 'granted'
mattjala
reviewed
Mar 18, 2024
|
|
||
| - GET /datasets/<id> - granted (returns HTTP Status 200 - OK) | ||
| - POST /datasets/<id>/value - granted (returns HTTP Status 200 - OK) | ||
| - PUT /datasets/<id>/shape) - grant (returns HTTP Status 200 - OK) |
mattjala
reviewed
Mar 18, 2024
|
|
||
| - GET /datasets/<id> - granted (returns HTTP Status 200 - OK) | ||
| - POST /datasets/<id>/value - granted (returns HTTP Status 200 - OK) | ||
| - PUT /datasets/<id>/shape) - grant (returns HTTP Status 200 - OK) |
mattjala
reviewed
Mar 18, 2024
|
|
||
| - GET /datasets/<id> - granted (returns HTTP Status 200 - OK) | ||
| - POST /datasets/<id>/value - granted (returns HTTP Status 200 - OK) | ||
| - PUT /datasets/<id>/shape) - grant (returns HTTP Status 200 - OK) |
mattjala
reviewed
Mar 18, 2024
| Use Azure Front Door for SSL/https with HSDS on AKS | ||
|
|
||
| With the instructions in *kubernetes_install_azure.md*, you can deploy | ||
| hsds to Azure Kubernetes Service (AKS) and access it over http using the |
mattjala
reviewed
Mar 18, 2024
| @@ -0,0 +1,219 @@ | |||
| Bug Reports & Contributions | |||
There was a problem hiding this comment.
This whole doc still refers to h5py
mattjala
reviewed
Mar 18, 2024
| @@ -0,0 +1,220 @@ | |||
| .. _faq: | |||
mattjala
reviewed
Mar 18, 2024
| @@ -0,0 +1,230 @@ | |||
| Licenses and legal info | |||
mattjala
reviewed
Mar 18, 2024
| @@ -0,0 +1,35 @@ | |||
| .. _quick: | |||
mattjala
reviewed
Mar 18, 2024
| @@ -0,0 +1,107 @@ | |||
| .. _related_projects: | |||
mattjala
reviewed
Mar 18, 2024
| @@ -0,0 +1,44 @@ | |||
| .. _release_guide: | |||
mattjala
reviewed
Mar 18, 2024
| - name: Attribute | ||
| description: Operations involving Attributes. | ||
| - name: ACLS | ||
| description: Operations involving Attributes. |
There was a problem hiding this comment.
Attributes -> Access Control Lists
mattjala
reviewed
Mar 18, 2024
| @@ -0,0 +1,11 @@ | |||
| .. _whatsnew: | |||
|
I messed this up - didn't me to include commits from different branches. Let me try to create a new PR... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP review...