Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix POST_Links incorrectly returning all links #307

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

mattjala
Copy link
Contributor

@mattjala mattjala commented Feb 9, 2024

When providing a list of link titles and a list of group ids, POST_Links is ignoring the provided titles and returning all links in the provided groups. It should return links with the specified titles from each target group, similar to PUT_Links.

@mattjala mattjala added the bug label Feb 9, 2024
@mattjala mattjala force-pushed the post_links_group_list_fix branch from fe799a1 to 5a15989 Compare February 9, 2024 17:49
@mattjala mattjala force-pushed the post_links_group_list_fix branch from 5a15989 to eb0a3f3 Compare February 9, 2024 17:50
Copy link
Member

@jreadey jreadey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jreadey jreadey merged commit a795cd0 into HDFGroup:master Feb 14, 2024
7 checks passed
@mattjala mattjala deleted the post_links_group_list_fix branch February 14, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants