Support requests with long URL #294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjala
added
enhancement
ci/cd
This was referenced Dec 18, 2023
|
After a discussion, it seems like a better solution might be to handle this with something similar to the changes in #295, where long URLs are sent as part of the body of a POST request instead of in the URL. |
|
Long link names are handled in #296 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for users to have link/group names up to about 64Kb, which the main library supports.
The specific choice of 67584 for the default max size is
65 * 1024 + 2048. This is because the library's API tests include a link with a name that is65 * 1024bytes long, and 2048 bytes should be enough to store the rest of the URL.