Fix jsonToArray on None array #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjala
force-pushed
the
fix_json_to_array_empty_compound_read
branch
from
aad10f6 to
d983841
Compare
|
Good - not sure what I was thinking with the "if None in data_json...". |
mattjala
force-pushed
the
fix_json_to_array_empty_compound_read
branch
2 times, most recently
from
49a8638 to
20c3c6f
Compare
mattjala
commented
Nov 3, 2023
| """ | ||
|
|
||
|
|
||
| def _bytesArrayToList(data): |
There was a problem hiding this comment.
This isn't used anywhere else, so I just removed it.
mattjala
force-pushed
the
fix_json_to_array_empty_compound_read
branch
from
20c3c6f to
5aaab9e
Compare
mattjala
force-pushed
the
fix_json_to_array_empty_compound_read
branch
from
5aaab9e to
b0b7158
Compare
|
Why do you have the extra parens? e.g. |
Force of habit from working in C. I'll clean those up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same issue that was partially fixed in #237, where
Noneelements in avaluearray caused issues in the helperjsonToArray. This covers the case where the entirevaluearray isNone(e.g. an attribute that was created but not written to). It now returns an empty numpy array instead of throwing an exception.This also makes HSDS log the error messages
jsonToArrayproduces, and adds a try/except block when doing a bytes decode that can fail.