Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for binary transfer of fixed UTF8 string #283

Closed
wants to merge 3 commits into from

Conversation

mattjala
Copy link
Contributor

@mattjala mattjala commented Nov 1, 2023

Branched off of #278, see this comment for more information.

@jreadey
Copy link
Member

jreadey commented Nov 2, 2023

@mattjala - I copied your tests to the fixed-utf8 branch

@mattjala
Copy link
Contributor Author

mattjala commented Nov 2, 2023

@mattjala - I copied your tests to the fixed-utf8 branch

It looks like you didn't bring in the binary attribute test testPutFixedUTF8StringAttributeBinary, or the changes to testPutFixedUTF8StringAttribute

@fortnern fortnern marked this pull request as draft November 2, 2023 16:11
@mattjala
Copy link
Contributor Author

mattjala commented Nov 3, 2023

These tests were added to main PR - closing this.

@mattjala mattjala closed this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants