Allow PUT shape to reduce extent #266
Conversation
| # H5D_COMPACT and H5D_CONTIGUOUS will not have a dims key | ||
| # Check the layout dict in dset_json to see if it's | ||
| # defined there | ||
| if "layout" in dset_json: |
There was a problem hiding this comment.
Isn't this section redundant, since getDatasetLayout already checks for a layout directly in dset_json?
There was a problem hiding this comment.
It's a bit hacky - the getDatasetLayout returns either the layout in CreationProperties or the layout key in dset_json. The idea is that the CreationProperties is just what the client passed in on POST dataset where the layout in dset_json is the actual layout used (e.g. HSDS may decide to use a larger chunksize). In the case here, we don't want CONTIGUOUS or COMPACT, so get dset_json["layout"] if that's the case.
|
After decreasing and then increasing size, the new positions in the dataset should have a value equal to fill value, not whatever was written there before the size was decreased. See the modified test in #267 |
Enable PUT shape to reduce extent
Also - fix errors showing up in async process.