Enable fancy selection with multiple coordinates (#388)

* wip for fancy indexing with multiple coord list

* pointsel update

* support fancy selection with multiple coords

* fix flake8 error

hsds/chunk_sn.py

@@ -17,6 +17,7 @@
 import base64
 import math
 import numpy as np
+
 from json import JSONDecodeError
 from asyncio import IncompleteReadError
 from aiohttp.web_exceptions import HTTPException, HTTPBadRequest

hsds/dset_lib.py

@@ -294,7 +294,7 @@ def getChunkItem(chunkid):
                 kwargs = {"chunk_index": chunk_index, "factors": table_factors}
                 _get_arr_pts(arr_points, arr_index, pt, **kwargs)
 
-        msg = f"got chunktable - {len(arr_points)} entries, calling getSelectionData"
+        msg = f"got chunktable - {len(arr_points)} entries, calling getChunkLocations"
         log.debug(msg)
         # this call won't lead to a circular loop of calls since we've checked
         # that the chunktable layout is not H5D_CHUNKED_REF_INDIRECT

hsds/dset_sn.py

@@ -745,6 +745,7 @@ async def POST_Dataset(request):
     dims = None
     shape_json = {}
     rank = 0
+    chunk_size = None
 
     if "shape" not in body:
         shape_json["class"] = "H5S_SCALAR"
@@ -858,19 +859,21 @@ async def POST_Dataset(request):
     else:
         creationProperties = {}
 
+    # TBD: check for invalid layout class...
     if layout_props:
-        if layout_props["class"] in ("H5D_COMPACT", "H5D_CONTIGUOUS"):
-            # treat compact and contiguous as chunked
+        if layout_props["class"] == "H5D_CONTIGUOUS":
+            # treat contiguous as chunked
             layout_class = "H5D_CHUNKED"
         else:
             layout_class = layout_props["class"]
-
     elif shape_json["class"] != "H5S_NULL":
         layout_class = "H5D_CHUNKED"
     else:
         layout_class = None
 
-    if layout_class:
+    if layout_class == "H5D_COMPACT":
+        layout = {"class": "H5D_COMPACT"}
+    elif layout_class:
         # initialize to H5D_CHUNKED
         layout = {"class": "H5D_CHUNKED"}
     else:
@@ -1035,6 +1038,12 @@ async def POST_Dataset(request):
                 log.warn(msg)
                 raise HTTPBadRequest(reason=msg)
 
+            if f_in and chunk_size is None:
+                # filters can only be used with chunked datasets
+                msg = "Filters can only be used with chunked datasets"
+                log.warning(msg)
+                raise HTTPBadRequest(reason=msg)
+
             f_out = []
             for filter in f_in:
                 if isinstance(filter, int) or isinstance(filter, str):