Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the use of -commons linking option on Darwin #3581

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Removed the use of -commons linking option on Darwin #3581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68cecdb
removed the use of -commons linking option on Darwin as COMMON and EQ…
brtnfld Sep 22, 2023
3d2a15c
added release note
brtnfld Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1074,14 +1074,6 @@ H5_FORTRAN_SHARED="no"
if test "X${HDF_FORTRAN}" = "Xyes" && test "X${enable_shared}" != "Xno"; then
AC_MSG_CHECKING([if shared Fortran libraries are supported])
H5_FORTRAN_SHARED="yes"
## tell libtool to do the right thing with COMMON symbols, this fixes
## corrupt values with COMMON and EQUIVALENCE when building shared
## Fortran libraries on OSX with gnu and Intel compilers (HDFFV-2772).
case "`uname`" in
Darwin*)
H5_LDFLAGS="$H5_LDFLAGS -Wl,-commons,use_dylibs"
;;
esac

## Report results of check(s)

Expand Down
2 changes: 0 additions & 2 deletions fortran/src/H5_ff.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
! PURPOSE
! This module is used to pass C stubs for H5 Fortran APIs. The C stubs are
! packed into arrays in H5_f.c and these arrays are then passed to Fortran.
! This module then uses EQUIVALENCE to assign elements of the arrays to
! Fortran equivalent C stubs.
!
! NOTES
! The size of the C arrays in H5_f.c has to match the values of the variables
Expand Down
5 changes: 5 additions & 0 deletions release_docs/RELEASE.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,11 @@ New Features
h5pget_file_space_page_size_f, h5pset_file_space_page_size_f,
h5pget_file_space_strategy_f, h5pset_file_space_strategy_f

- Removed "-commons" linking option on Darwin, as COMMON and EQUIVALENCE
are no longer used in the Fortran source.

Fixes GitHub issue #3571

C++ Library:
------------
-
Expand Down