Feature/hapi 509 base layout #3
Conversation
| @@ -0,0 +1 @@ | |||
| REACT_APP_ENVIRONMENT=testnet | |||
There was a problem hiding this comment.
output directory shouldn't be commited to the directory. It should be in the root directory .gitignore. This way we can generate arbitrary outputs without messing with the project Git tree.
| @@ -0,0 +1,51 @@ | |||
| // SPDX-License-Identifier: MIT | |||
There was a problem hiding this comment.
We don't need the contract source code in the output directory. Please add the contracts directory removal to the generator script after it's done with ABI and typings generation.
| @@ -0,0 +1,48 @@ | |||
| { | |||
There was a problem hiding this comment.
Please add package.json and package-lock.json to template directory so we can populate it every time we run the generator.
| @@ -0,0 +1,9 @@ | |||
| import { HardhatUserConfig } from "hardhat/config"; | |||
There was a problem hiding this comment.
Hardhat config should be in the root directory of the project, as it's not a part of the output.
Rememeber, output should only contain files we need to deploy to show the interface.
| @@ -0,0 +1,43 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
Please move the contents of public directory to the template.
| @@ -0,0 +1,26 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
Please move the contents of src directory to the template. It should not contain artifacts and contracts. Please copy those as a part of generation script. It's okay if the code in template/src complains about missing ABI.
| @@ -0,0 +1,13 @@ | |||
| { | |||
There was a problem hiding this comment.
This tsconfig.json should be a part of the template.
No description provided.