Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed card update issue while mode switch #319

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

Sushil010
Copy link
Contributor

Description

Fixed issue where only the background color of the page changed but the card components retain their color, which causes visual inconsistencies. The card backgrounds and text colors has now also switch between dark and light modes.

Fixes: #296

Type of Change

  • Profile Added
  • Project Added
  • [X ] Bug fix
  • New feature
  • Documentation update
  • Other (please specify):

Go to main page
2. At top right toggle to light mode or dark mode
3.You will see update in card design or color according to desired mode

  • [ X] I have performed a self-review of my code.
  • [ X] I have commented my code, particularly in hard-to-understand areas.
  • [ X] I have made corresponding changes to the documentation (if applicable).
  • [ X] My changes generate no new warnings.
  • [ X] I have added tests to cover my changes (if applicable).
  • [ X] All new and existing tests pass.

Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-profile ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 11:38am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Sushil010! Thanks for creating the pull request.
Soon the maintainers/owner will review it and provide you with feedback/suggestions.
Make sure to star this awesome repository and follow the account!

@Gyanthakur Gyanthakur merged commit 483b0df into Gyanthakur:main Oct 31, 2024
8 checks passed
@Sushil010 Sushil010 deleted the fix/dark-mode-issue branch October 31, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cards Not Updating on Dark/Light Mode Toggle
2 participants