reinit value and buffer on mask change #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murzvo
force-pushed
the
reinit-after-mask-change
branch
2 times, most recently
from
c47f0e4 to
fea820c
Compare
murzvo
force-pushed
the
reinit-after-mask-change
branch
from
fea820c to
5750d9b
Compare
|
@rylanc Could you help me with build? I can't understand what is wrong |
murzvo
force-pushed
the
reinit-after-mask-change
branch
from
5750d9b to
e9a7527
Compare
|
@murzvo It looks like there was a compatibility issue with my tests and later versions of React. I just updated the tests. Try merging and see if that fixes things. |
murzvo
force-pushed
the
reinit-after-mask-change
branch
from
e9a7527 to
30c34e1
Compare
|
@rylanc Everything looks OK now. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To correctly apply new changes on masked input