Add iPhone 15 #1429
Merged
Add iPhone 15 #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GuillaumeGomez this PR is ready for review. |
GuillaumeGomez
approved these changes
Dec 18, 2024
|
This is wesome, thanks a lot! |
GuillaumeGomez
merged commit 415c692
into
GuillaumeGomez:missing-cpu-brands
67 checks passed
thank you for the great library! 🍺 |
GuillaumeGomez
pushed a commit
that referenced
this pull request
Dec 27, 2024
Fix CPU names for iPhone and iPad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @GuillaumeGomez can you please review? Please feel free to commit on my branch.
This change adds it for iPhones only, I think people can add iPad when they need it (otherwise this list can get pretty long...). This supports iPhone down to the first bionic chip. The internal identifier is misleading, I found it from these lists: