add autoblock check #1467

K0itoyuu · 2024-05-10T12:48:26Z

No description provided.

rejomy · 2024-05-10T13:31:05Z

Hello man! What does this line do in the config?

AutoBlock:
  setbackvl: -1 # silent

K0itoyuu · 2024-05-10T13:42:02Z

你好，朋友！这行在配置中有什么作用？
AutoBlock:
  setbackvl: -1 # silent

Personal preference

Anthony01M · 2024-05-10T13:44:31Z

Was this tested? And the one in the config fairly sure it does nothing??

K0itoyuu · 2024-05-10T14:01:48Z

Was this tested? And the one in the config fairly sure it does nothing??

It has been tested in 0ms, 30ms, 80ms, 160ms, and 200ms environments

Anthony01M · 2024-05-10T14:03:01Z

Was this tested? And the one in the config fairly sure it does nothing??

It has been tested in 0ms, 30ms, 80ms, 160ms, and 200ms environments

Server & client version??

K0itoyuu · 2024-05-10T14:04:53Z

Was this tested? And the one in the config fairly sure it does nothing??

Was this tested? And the one in the config fairly sure it does nothing??

It has been tested in 0ms, 30ms, 80ms, 160ms, and 200ms environments

Server & client version??
test on 1.8.9,1.12.2,1.20.4(no viaversion)

K0itoyuu · 2024-05-10T14:24:08Z

Was this tested? And the one in the config fairly sure it does nothing??

I see, I used to develop other anti-cheats when the flagAndAlert() method can be used to setback directly, but grim is different, I'm going to re-push the code

AoElite · 2024-05-11T04:36:20Z

When you cancel packets you need to check if it flags & use the method that checks if it should modify packets. Also since you are using bukkit methods to check if they are blocking it's probably going to false with latency.

ManInMyVan · 2024-05-11T04:22:03Z

src/main/java/ac/grim/grimac/checks/impl/autoblock/AutoBlockA.java

+
+            //Even blocking due to a delay will send Interact before then
+            if (wrapper.getAction().equals(WrapperPlayClientInteractEntity.InteractAction.ATTACK)) {
+                if (this.player.bukkitPlayer.isBlocking()) {


use player.packetStateData.slowedByUsingItem to avoid falses due to desync like https://github.com/GrimAnticheat/Grim/blob/2.0/src/main/java/ac/grim/grimac/events/packets/PacketPlayerAttack.java#L48

I've tried slowedByUseItem, but it doesn't work

I've tried slowedByUseItem, but it doesn't work

Try handling it right after BadPacketsW in https://github.com/GrimAnticheat/Grim/blob/2.0/src/main/java/ac/grim/grimac/events/packets/PacketPlayerAttack.java

ManInMyVan · 2024-05-11T04:23:46Z

src/main/java/ac/grim/grimac/checks/impl/autoblock/AutoBlockA.java

+                    if (wrapper.getEntityId() != this.lastInteractEntity) {
+                        if (isAboveSetbackVl()) this.player.getSetbackTeleportUtil().executeNonSimulatingSetback();
+                        flagAndAlert();
+                        event.setCancelled(true);


Replace this with

if (shouldModifyPackets()) { event.setCancelled(true); player.onPacketCancel(); }

ManInMyVan · 2024-05-11T04:25:10Z

src/main/java/ac/grim/grimac/checks/impl/autoblock/AutoBlockA.java

+import com.github.retrooper.packetevents.protocol.packettype.PacketType;
+import com.github.retrooper.packetevents.wrapper.play.client.WrapperPlayClientInteractEntity;
+
+@CheckData(name = "AutoBlockA (Interact)",configName = "AutoBlock",setback = 1)


Add spaces between the commas

ManInMyVan · 2024-05-11T04:26:17Z

src/main/java/ac/grim/grimac/checks/impl/autoblock/AutoBlockB.java

+            if (wrapper.getAction().equals(WrapperPlayClientInteractEntity.InteractAction.ATTACK)) {
+                if (this.player.bukkitPlayer.isBlocking()) {
+                    if (this.lastUseItem == -1L && this.useItem == -1L) {
+                        this.useItem = this.player.lastBlockPlaceUseItem;


This only works on 1.8 servers iirc

ManInMyVan · 2024-05-11T04:27:56Z

src/main/java/ac/grim/grimac/checks/impl/autoblock/AutoBlockB.java

+        if (event.getPacketType().equals(PacketType.Play.Client.INTERACT_ENTITY)) {
+            WrapperPlayClientInteractEntity wrapper = new WrapperPlayClientInteractEntity(event);
+            if (wrapper.getAction().equals(WrapperPlayClientInteractEntity.InteractAction.ATTACK)) {
+                if (this.player.bukkitPlayer.isBlocking()) {


Again, use player.packetStateData.slowedByUsingItem to avoid falses due to desync like https://github.com/GrimAnticheat/Grim/blob/2.0/src/main/java/ac/grim/grimac/events/packets/PacketPlayerAttack.java#L48

ManInMyVan · 2024-05-11T04:28:15Z

src/main/java/ac/grim/grimac/checks/impl/autoblock/AutoBlockB.java

+
+                    //vanilla is unable to do blocking when sending more than two interact_entity packets
+                    if (this.useItem == this.lastUseItem) {
+                        setbackIfAboveSetbackVL();


Again, why setback?

ManInMyVan · 2024-05-11T04:28:35Z

src/main/java/ac/grim/grimac/checks/impl/autoblock/AutoBlockB.java

+import com.github.retrooper.packetevents.protocol.packettype.PacketType;
+import com.github.retrooper.packetevents.wrapper.play.client.WrapperPlayClientInteractEntity;
+
+@CheckData(name = "AutoBlockB (MultiActions)",configName = "AutoBlock",setback = 1)


Again, add spaces

ManInMyVan · 2024-05-11T04:30:11Z

src/main/java/ac/grim/grimac/checks/impl/autoblock/AutoBlockB.java

+                    //vanilla is unable to do blocking when sending more than two interact_entity packets
+                    if (this.useItem == this.lastUseItem) {
+                        setbackIfAboveSetbackVL();
+                        flagAndAlert("Duplicate tick");


Why add verbose when the verbose is always the same?

ManInMyVan · 2024-05-11T04:31:58Z

src/main/java/ac/grim/grimac/checks/impl/autoblock/AutoBlockA.java

+            if (wrapper.getAction().equals(WrapperPlayClientInteractEntity.InteractAction.ATTACK)) {
+                if (this.player.bukkitPlayer.isBlocking()) {
+                    if (wrapper.getEntityId() != this.lastInteractEntity) {
+                        setbackIfAboveSetbackVL();


Why setback?

ManInMyVan · 2024-05-11T04:46:22Z

src/main/java/ac/grim/grimac/checks/impl/autoblock/AutoBlockA.java

+                        setbackIfAboveSetbackVL();
+                        flagAndAlert();
+                        event.setCancelled(true);


flagAndAlert() returns something, check it before you do anything

if (flagAndAlert()) { ... }

ManInMyVan · 2024-05-11T04:50:15Z

src/main/java/ac/grim/grimac/checks/impl/autoblock/AutoBlockB.java

+                        setbackIfAboveSetbackVL();
+                        flagAndAlert("Duplicate tick");


if (flagAndAlert("Duplicate tick")) { setbackIfAboveSetbackVL(); }

K0itoyuu · 2024-05-11T06:53:46Z

When you cancel packets you need to check if it flags & use the method that checks if it should modify packets. Also since you are using bukkit methods to check if they are blocking it's probably going to false with latency.

i will recode it

ManInMyVan · 2024-05-11T16:01:00Z

src/main/java/ac/grim/grimac/checks/impl/autoblock/AutoBlockA.java

+
+            //Even blocking due to a delay will send Interact before then
+            if (wrapper.getAction().equals(WrapperPlayClientInteractEntity.InteractAction.ATTACK)) {
+                if (this.player.packetStateData.slowedByUsingItem || this.player.packetStateData.wasSlowedByUsingItem) {


wasSlowedByUsingItem was added to patch switchitem noslow, and is only updated every client tick and on slot changes, this could cause false positives.

ManInMyVan · 2024-05-11T20:52:40Z

AutoBlockB is easily falsable https://streamable.com/yto3z0

ManInMyVan · 2024-05-11T21:10:52Z

src/main/java/ac/grim/grimac/checks/impl/autoblock/AutoBlockB.java

+                        this.lastUseItem = this.useItem;
+                        return;
+                    }
+                    alert("useItem=" + this.useItem + ", lastUseItem=" + this.lastUseItem);


unless if this is for debug, this should be flagAndAlert, not just alert

Since I couldn't find a debug method in grim, I just used alert instead

ManInMyVan · 2024-05-11T21:15:29Z

src/main/java/ac/grim/grimac/checks/impl/autoblock/AutoBlockB.java

+import com.github.retrooper.packetevents.protocol.packettype.PacketType;
+import com.github.retrooper.packetevents.wrapper.play.client.WrapperPlayClientInteractEntity;
+
+@CheckData(name = "AutoBlockB (MultiActions)", configName = "AutoBlock", setback = 1)


separate AutoBlockA and AutoBlockB in the config

Anthony01M · 2024-05-12T05:55:11Z

Please solve the conflicts and put this PR as draft; and you should probably handle 1.9+ servers/clients (second hand; shield, etcetera) at the same time.

K0itoyuu · 2024-05-12T06:08:08Z

Please solve the conflicts and put this PR as draft; and you should probably handle 1.9+ servers/clients (second hand; shield, etcetera) at the same time.

This check has been tested in 1.9+.

Anthony01M · 2024-05-15T20:03:58Z

Please solve the conflicts and put this PR as draft; and you should probably handle 1.9+ servers/clients (second hand; shield, etcetera) at the same time.

This check has been tested in 1.9+.

I'm saying with ViaVersion, you previously said without ViaVersion/Backwards/Rewind.
Please review your conflicts and also remove buffer in AutoBlockA (since it's useless?), it should look something like this:

player.onPacketCancel("AutoBlockA (InteractEntity)"); should be changed to player.onPacketCancel(); since there's no "reason" in Grim forgot to remove that part.

ManInMyVan · 2024-05-18T04:46:20Z

If this gets merged we should rename BadPacketsV to AutoBlockC

ManInMyVan · 2024-06-04T07:14:33Z

3 things:

Fix merge conflicts
Add these to the punishments config ("AutoBlock" can be used instead of specifying them individually)
Do this:

If this gets merged we should rename BadPacketsV to AutoBlockC

add autoblock check

cc52607

Koitoyuu added 2 commits May 10, 2024 22:28

setback

4c54ead

cleaned code

e1ab6bf

ManInMyVan reviewed May 11, 2024

View reviewed changes

cleaned code

94c16a5

ManInMyVan reviewed May 11, 2024

View reviewed changes

improve

ea353b3

K0itoyuu closed this May 16, 2024

K0itoyuu reopened this May 16, 2024

rejomy mentioned this pull request Oct 24, 2024

patch full autoblock and desync noslows #1757

Draft

ManInMyVan added the status: rebase required The pull request needs rebasing onto the merge branch label Dec 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add autoblock check #1467

add autoblock check #1467

K0itoyuu commented May 10, 2024

rejomy commented May 10, 2024 •

edited

Loading

K0itoyuu commented May 10, 2024

Anthony01M commented May 10, 2024

K0itoyuu commented May 10, 2024

Anthony01M commented May 10, 2024

K0itoyuu commented May 10, 2024

K0itoyuu commented May 10, 2024

AoElite commented May 11, 2024

ManInMyVan May 11, 2024

K0itoyuu May 11, 2024

ManInMyVan May 11, 2024 •

edited

Loading

ManInMyVan May 11, 2024 •

edited

Loading

K0itoyuu May 11, 2024

ManInMyVan May 11, 2024

ManInMyVan May 11, 2024 •

edited

Loading

ManInMyVan May 11, 2024

ManInMyVan May 11, 2024

ManInMyVan May 11, 2024

ManInMyVan May 11, 2024

ManInMyVan May 11, 2024

ManInMyVan May 11, 2024 •

edited

Loading

ManInMyVan May 11, 2024 •

edited

Loading

K0itoyuu commented May 11, 2024

ManInMyVan May 11, 2024

ManInMyVan commented May 11, 2024

ManInMyVan May 11, 2024

K0itoyuu May 12, 2024

ManInMyVan May 11, 2024

K0itoyuu May 12, 2024 •

edited

Loading

Anthony01M commented May 12, 2024 •

edited

Loading

K0itoyuu commented May 12, 2024

Anthony01M commented May 15, 2024 •

edited

Loading

ManInMyVan commented May 18, 2024

ManInMyVan commented Jun 4, 2024

add autoblock check #1467

Are you sure you want to change the base?

add autoblock check #1467

Conversation

K0itoyuu commented May 10, 2024

rejomy commented May 10, 2024 • edited Loading

K0itoyuu commented May 10, 2024

Anthony01M commented May 10, 2024

K0itoyuu commented May 10, 2024

Anthony01M commented May 10, 2024

K0itoyuu commented May 10, 2024

K0itoyuu commented May 10, 2024

AoElite commented May 11, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ManInMyVan May 11, 2024 • edited Loading

Choose a reason for hiding this comment

ManInMyVan May 11, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ManInMyVan May 11, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ManInMyVan May 11, 2024 • edited Loading

Choose a reason for hiding this comment

ManInMyVan May 11, 2024 • edited Loading

Choose a reason for hiding this comment

K0itoyuu commented May 11, 2024

Choose a reason for hiding this comment

ManInMyVan commented May 11, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

K0itoyuu May 12, 2024 • edited Loading

Choose a reason for hiding this comment

Anthony01M commented May 12, 2024 • edited Loading

K0itoyuu commented May 12, 2024

Anthony01M commented May 15, 2024 • edited Loading

ManInMyVan commented May 18, 2024

ManInMyVan commented Jun 4, 2024

rejomy commented May 10, 2024 •

edited

Loading

ManInMyVan May 11, 2024 •

edited

Loading

ManInMyVan May 11, 2024 •

edited

Loading

ManInMyVan May 11, 2024 •

edited

Loading

ManInMyVan May 11, 2024 •

edited

Loading

ManInMyVan May 11, 2024 •

edited

Loading

K0itoyuu May 12, 2024 •

edited

Loading

Anthony01M commented May 12, 2024 •

edited

Loading

Anthony01M commented May 15, 2024 •

edited

Loading