Added strict-boolean-expression rule and fixed lint errors

GridProtectionAlliance · Mar 12, 2024 · ffb39ff · ffb39ff
1 parent ad0b52d
commit ffb39ff
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 8 deletions.
diff --git a/common-pages/.eslintrc b/common-pages/.eslintrc
@@ -1,9 +1,7 @@
 {
     "root": true,
     "parser": "@typescript-eslint/parser",
-    "plugins": [
-      "@typescript-eslint"
-    ],
+    "plugins": ["@typescript-eslint"],
     "extends": [
       "eslint:recommended",
       "plugin:@typescript-eslint/eslint-recommended",
@@ -13,6 +11,21 @@
       "@typescript-eslint/no-namespace": "off",
       "@typescript-eslint/no-empty-function": "warn",
       "@typescript-eslint/ban-types": "warn",
-      "prefer-const": "warn"
+      "prefer-const": "warn",
+      "@typescript-eslint/strict-boolean-expressions": ["error", {
+        "allowString": false,
+        "allowNumber": false,
+        "allowNullableObject": false,
+        "allowNullableBoolean": false,
+        "allowNullableString": false,
+        "allowNullableNumber": false,
+        "allowNullableEnum" : false,
+        "allowAny": false,
+        "allowRuleToRunWithoutStrictNullChecksIKnowWhatIAmDoing": false
+      }]
+    },
+    "ignorePatterns": ["package/**/*", "__tests__", "lib"],
+    "parserOptions" : {
+      "project": ["./tsconfig.json"]
     }
   }
diff --git a/common-pages/src/Setting.tsx b/common-pages/src/Setting.tsx
@@ -155,7 +155,7 @@ function Setting(props: IProps)  {
             dispatch(props.SettingsSlice.DBAction({verb: 'POST', record: editnewSetting}))
           if (conf && editNew === 'Edit')
             dispatch(props.SettingsSlice.DBAction({verb: 'PATCH', record: editnewSetting}))
-          if (!conf && isBtn)
+          if (!conf && (isBtn ?? false))
             setShowWarning(true);
           setShowModal(false);
         }}

diff --git a/common-pages/tsconfig.json b/common-pages/tsconfig.json
@@ -6,8 +6,8 @@
     "outDir": "./lib",
     "strict": true,
     "jsx": "react",
-    "skipLibCheck": true
-
+    "skipLibCheck": true,
+    "strictNullChecks": true
   },
     "include": ["src"],
     "exclude": ["node_modules", "**/__tests__/*"]

diff --git a/react-table/tsconfig.json b/react-table/tsconfig.json
@@ -6,7 +6,8 @@
       "outDir": "./lib",
       "strict": true,
       "jsx": "react",
-      "skipLibCheck": true
+      "skipLibCheck": true,
+      "strictNullChecks": true
     },
     "include": ["src"],
     "exclude": ["node_modules", "**/__tests__/*"]