SC-206 Filters out used Channels #531
Conversation
| function filterChannels(chs: OpenXDA.Types.Channel[]) { | ||
| return chs.filter(ch => | ||
| !(ch.Asset.length > 0) | ||
| ); | ||
| } |
There was a problem hiding this comment.
Can this be wrapped with a useMemo instead of being a function? That way, we only run this function once any time props.Channels changes and not a bunch of times every rerender.
There was a problem hiding this comment.
I'm not sure that's true. I don't think we run this function on every rerender. It just get's defined as a new function on every re-render. that may be perfectly fine.
But the real question is why are we filtering through this twice?
ChannelSelector will filter it by whatever matches the Search state, so it will run through the list anyway. It would make sense to add this Filter there instead of filtering it here and in ChannelSelector
|
Thinking this through, we may need/want to retain the ability to "Unselect" Channels already tied to this asset. otherwhise there is an issue in the workflow where someone accidentally assigns a channel, closes the modal and has no way of undoing that. |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Added a filterChannel function