-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release version 1.9.7 #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improvment to the create_test_suite and the AAATestBackendAPI
BDonnot
commented
Dec 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good (wait for tests to pass)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grid2op/Exceptions/PowerflowExceptions.py
file and move theDivergingPowerflow
as part of the BackendException. If you imported (to be avoided)with
from grid2op.Exceptions.PowerflowExceptions import PowerflowExceptions
simply do
from grid2op.Exceptions import PowerflowExceptions
and nothingwill change.
Exceptions
",module. This is both consistent with python practice but allows also to make the
difference between the files in the
module and the class imported. This should have little to no impact on all codes but to "upgrade"
instead of
from grid2op.Exceptions.XXX import PowerflowExceptions
(which you should not have done in the first place)just do
from grid2op.Exceptions import PowerflowExceptions
. Expect other changes like this for other grid2op modulesin the near future.
gridobj_cls.shape()
andgridobj_cls.dtype()
togridobj_cls.shapes()
andgridobj_cls.dtypes()
to be more clear when dealing with action_space and observation_space (where
shape
anddtype
are attribute and not functions)This change means you can still use
act.shape()
andact.dtype()
but thatact_space.shape
andact_space.dtype
are nowclearly properties (and NOT attribute). For the old function
gridobj_cls.dtype()
you can now usegridobj_cls.dtypes()
shunts_data_available
#550 : issue withshunts_data_available
now better handledthe
topo_vect
returns value between 1 and 2.topo_vect
for each type of elements.