Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove #forge:seeds seed oil recipe #2041

Merged
merged 5 commits into from
Sep 30, 2024

Conversation

JuiceyBeans
Copy link
Contributor

@JuiceyBeans JuiceyBeans commented Sep 27, 2024

What

Removes recipes for seed oil from #forge:seeds so that it doesn't conflict with the vanilla seed recipes

Implementation

Also added a new recipe for wheat seeds -> seed oil, since the old recipe depended on #forge:seeds
Right now, it does 10mB of seed oil, but since wheat seeds are the most easily farmable, I think the output for wheat seeds should be reduced and the rest be bumped up

Outcome

Seed oil can no longer be obtained by extraction using #forge:seeds, players will be required to use vanilla seeds. Pack devs will have to add new recipes accordingly if they wish

Potential Compatibility Issues

Existing setups using seeds from other mods will no longer work unless pack devs add new recipes

@JuiceyBeans JuiceyBeans requested a review from a team as a code owner September 27, 2024 10:50
@screret screret added the type: bug Something isn't working label Sep 27, 2024
Copy link
Member

@screret screret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuiceyBeans JuiceyBeans changed the title Remove redundant seed oil recipes Remove #forge:seeds seed oil recipe Sep 28, 2024
@JuiceyBeans JuiceyBeans requested a review from screret September 28, 2024 23:18
@YoungOnionMC YoungOnionMC merged commit ce28829 into GregTechCEu:1.20.1 Sep 30, 2024
3 checks passed
krossgg pushed a commit that referenced this pull request Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants