Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yaml Documentation Update (tree and capture response objects) #383

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

sam-rice
Copy link
Contributor

@sam-rice sam-rice commented Jul 7, 2024

Description

This branch updates the OpenAPI documentation for the tree and capture response objects according to the v2 domain model and project discussion on 7/04/24.

Details

The tree and capture database tables specified in the v2 domain model do not include a number of fields that the web map client relies on:

  • grower_id
  • growing_organization_id
  • country_name
  • token_id
  • approved
  • species_name
  • species_desc
  • wallet_name
  • wallet_id

Since the denormalized response objects coming from the query api have not been specified, a discussion was required to decide where these missing fields would likely come from. A number of decisions were made during the 7/04/24 meeting, but changes will be ongoing as v2 development progresses.

As of now:

  • Because the Greenstand product changes (v2) will allow a single tree to be cared for and sponsored by different growers and organizations at different stages of the tree's life, data specific to growers, wallets, and organizations will be part of the capture entity only. trees are more dynamic entities that may change over time.
  • Species data:
    • Because species information can be updated during the capture verification process (if a tree were previously misidentified, for example), future discussions will need to address how tree.species_id in the tree database table will stay updated.
    • species_desc and species_name fields may end up coming from a client-side request to the herbarium api in the future, but will be included on the tree response object, for now.

@dadiorchen 's Slack notes from 7/04/24 meeting:

dadior_slack_7_04

@sam-rice sam-rice changed the title feat: update api documentation yaml (tree and capture response objects) Yaml Documentation Update (tree and capture response objects) Jul 7, 2024
@dadiorchen dadiorchen merged commit a458fdc into Greenstand:main Jul 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants