-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new command to generate IntelliJ run configurations #48
Open
bernd
wants to merge
17
commits into
main
Choose a base branch
from
add/idea-run-configs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regenerate command picks up all ".xml.tmpl" files in the repository and fails on the run configuration template. So we use a different suffix to avoid that issue.
The renameio library doesn't work on Windows so we have to provide a wrapper.
thll
reviewed
Nov 28, 2024
idea/testdata/.config/idea/templates/run-configurations/data-node.env.template
Outdated
Show resolved
Hide resolved
idea/testdata/.config/idea/templates/run-configurations/data-node.run.xml.template
Show resolved
Hide resolved
The Data Node can auto-detect the correct location so we don't have to put the version number into the environment.
thll
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only scanned over the code but I tested the CLI command. Works great 👍
On Linux the *.localhost hostnames work automatically. On other operating systems the users have to add the names to /etc/hosts.
@bernd: Now that Graylog2/graylog2-server#20181 is merged, should we proceed with this PR? |
Aye! Let's finish it up in the new year. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
idea run-configs create
command creates IntelliJ run configurations for the Graylog Server, Data Node, and the DEV web server.