-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor bug fixes, island search functionality #80
Open
kfstevens87
wants to merge
49
commits into
GrapeshotGames:master
Choose a base branch
from
kfstevens87:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix island name font draw bug when zoomed out
…ridEditor_10-26-20.zip only the ones that had no merge issues with my own code.
…reparation for hopefully getting some automerge help with the significant 2021-04-26 changes
…ly needs attention on sizing and positioning of various elements.
… SelectedItem, bad parallelism, possible improper use of SaveFileDialog) Disable completely broken parallelism for drawing: UI objects have UI thread affinity. Welcome to WinForms 101! (could refactor so related methods don't touch UI objects, so left some of the code in place commented out, this was a more surgical thing for now) SaveFileDialog sometimes holding lock on the files, so stop using an instance and just new one up in a using block when needed here. (I'm a little fuzzy on some of that at this point, but it's definitely not worse) Revert a bunch of sizing to base GrapeShot implementations, I think. Change my island search to use a Regex.
…d to do cosmetics check, and islands.json has been reverted again.
…Same crap as the old save file dialog.)
…"HintTextBox" gets auto-removed from the designer if you edit in the designer, so...that's fun.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some values being overwritten
crashes when zoomed out and show island names checked
Add island search function!