Calculate iframe absolute offset relative to viewport when determining target #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to add the editor to a webpage where it would be located somewhere other than the document origin, I began to encounter issues dragging blocks into the editor, where they seemingly would only register if I hovered my finger around the bottom of the screen.
Some investigating demonstrated that this was because the _getTarget function attempts to use the iframe's absolute offset within the document when trying to determine which element within is being selected/focused. This offset is then subtracted from the coordinates of the touchpoint from the event. However, it appears that the event's coordinates are calculated in terms of an offset from viewport rather than an offset from the document origin.
After making this change, I no longer encountered issues with dragging blocks into the editor on my page.