Raise exception on socket disconnect #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5 +/- ##
==========================================
+ Coverage 87.7% 87.83% +0.13%
==========================================
Files 3 3
Lines 187 189 +2
Branches 19 20 +1
==========================================
+ Hits 164 166 +2
Misses 14 14
Partials 9 9
Continue to review full report at Codecov.
|
insideable
force-pushed
the
raise-disconnect-exception
branch
2 times, most recently
from
a3199a1 to
b43cecc
Compare
insideable
force-pushed
the
raise-disconnect-exception
branch
from
b43cecc to
e228f08
Compare
Open
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5 +/- ##
==========================================
+ Coverage 87.70% 87.83% +0.13%
==========================================
Files 3 3
Lines 187 189 +2
Branches 19 20 +1
==========================================
+ Hits 164 166 +2
Misses 14 14
Partials 9 9 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR provides control over disconnected socket situation: by default
readlinefrom disconnected socket returns empty string, and NATS subscriber falls in endless loop with eating 100% CPU resource.