-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup code #177
base: main
Are you sure you want to change the base?
Cleanup code #177
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Although CI passes, I am going to leave this rather large PR open for now. Feel free to give it a try (consider backing up your database beforehand) and report back when there are any issues with this. I will have a look at this again later on as well before actually merging. (The CodeQL errors are unrelated and have already existed in the old code.) |
Description
This PR performs a lot of cleanup on the existing code, including (but not limited to):
skip
after fixing the apparent issues.__import__
byimportlib
. This is required for the conversion tests as the previously used German locale does not define number words at the moment.How Has This Been Tested?
Types of changes
Checklist: