Fix: Skip face-swapping for images without detectable faces (#504) #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Gourieff I have raised a new PR. |
Wiikend92
reviewed
Dec 26, 2024
scripts/reactor_swapper.py
Outdated
|
|
||
| if len(faces) == 0: | ||
| logger.status("No face found so skipping this frame") | ||
| return faces | ||
| # Try halving det_size if no faces are found | ||
| if len(faces) == 0 and det_size[0] > 320 and det_size[1] > 320: |
There was a problem hiding this comment.
This code will no longer be executed because for the condition len(faces) == 0 to be true, you will already have returned from the function in the previous if block. Put your new code from above in an elseif on this if instead to avoid breaking this functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #504