Propose snapping recurrence #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
December 16, 2018 00:26
The ability for the user to define which day of the week should be considered the start of the week, was added in [4ab665b8764b3fe67b2bd63acf7d68f2eb97b911](GothenburgBitFactory/taskwarrior@4ab665b) and [fd823871f0ee840288d3b4fdd095cc2970f8adad](GothenburgBitFactory/taskwarrior@fd82387).
Otherwise, due to bootstrap.css, the "h5" headings end up with the same size, weight, and decoration as the "p" element text and are not visually obvious as headings.
Clarify similarities between these two programs' recurrence types, by incorporating material from [this comment](GothenburgBitFactory/taskwarrior#1835 (comment)). Strip extraneous prose.
into "Proposal: New 'rtype' attribute", for concision.
Both because that seems the most relevant place for it, and because the table was too narrow to accommodate so many columns with cells containing full sentences of text. Also delete the now-unnecessary "Notes" column from the `rtype` proposal table.
If you are very late buying birthday flowers, it might be better to wait until next year (depends on the person, I guess). But rent is more black-and-white: it is due regularly, and if not paid then the obligations accumulate. The replacement example was inspired by one of the examples given at https://orgmode.org/manual/Repeated-tasks.html
Useful to help distinguish it from `rtype:periodic` and `rtype:chained`. The replacement example was inspired by one of the examples given at https://orgmode.org/manual/Repeated-tasks.html
"Snapping" is a term that has currency already in software, especially in image editing tools. It refers to something that would otherwise be free-floating "snapping" instead to a grid of pre-defined intervals.
|
These PRs seem to not have been properly separated; could you try to fix this and only have one change per PR? Thank you! |
|
I'm not quite sure what you mean by "properly separated", sorry. My aim here was to create a branch that has a cohesive purpose, with each commit on that branch making a comprehensible change (documented in the commit message) towards that purpose. The resulting additions to the git log should therefore be very readable for future contributors, if you merge the PR. Hopefully that clears things up. If not, please let me know. Thanks! |
|
The recurrence design file has been moved to the taskwarrior repository and converted to Markdown 👉🏻 recurrence.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TW should probably gain an
rtype:snappingthat would be similar to Org-mode's++.