-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] Post Locking #6314
[Draft] Post Locking #6314
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
||
$send['lock_error'] = $error; | ||
} else { | ||
$new_lock = $this->set_post_lock( $post_id ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could just use wp_set_post_lock()
. No need to duplicate this code from core.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that function available via the REST API?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good point.
wp-admin/includes/post.php
would need to be loaded in the REST API.
But we cannot just copy the core code for license reasons.
return $response; | ||
} | ||
|
||
$user_id = $this->check_post_lock( $post_id ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could just use wp_check_post_lock()
. No need to duplicate this code from core.
@allan23 Would be great if you could sign the CLA above so we could build upon your contribution here. |
@googlebot I signed it! |
Closing in favor of #6497 |
Context
This is a draft PR of the Post Locking implementation (#3126)