Improve Story Discoverability on Frontend #2191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
Type: Enhancement
Codecov Report
@@ Coverage Diff @@
## master #2191 +/- ##
============================================
- Coverage 66.16% 66.13% -0.03%
- Complexity 296 305 +9
============================================
Files 640 641 +1
Lines 10474 10504 +30
============================================
+ Hits 6930 6947 +17
- Misses 3544 3557 +13
|
|
Size Change: +61 B (0%) Total Size: 806 kB
ℹ️ View Unchanged
|
spacedmonkey
reviewed
Jun 3, 2020
spacedmonkey
reviewed
Jun 3, 2020
spacedmonkey
reviewed
Jun 3, 2020
spacedmonkey
reviewed
Jun 3, 2020
spacedmonkey
reviewed
Jun 3, 2020
|
Do you think we have enough filters to intergrate with say yoast or jetpack seo tools? |
|
Related: Yoast/wordpress-seo#13446 #113 |
For now, I think so. But only by collaborating with Yoast & others and putting this out into the wild we'll know for sure. That's what the beta will be useful for. |
spacedmonkey
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sharing stories should render nice previews out of the box. This PR adds Open Graph & Twitter card output to achieve this.
Relevant Technical Choices
Adds a dedicated
Discoveryclass that deals with anything related to<head>metadata and such.To-do
User-facing changes
Testing Instructions
Addresses #1117