Bump WP version requirement to 6.4 #13731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swanand01
added
Group: WordPress
|
Size Change: 0 B Total Size: 2.76 MB ℹ️ View Unchanged
|
|
Plugin builds for 26321cb are ready 🛎️!
|
|
@swissspidy , I wasn't sure if Also, the PHP Unit tests against WP trunk are failing here too. |
This never needs changing anymore. I will update the issue template accordingly. Sorry for the confusion.
Yeah they will be failing everywhere :-) I'll have to find the core change that caused this and will check if we really need to adjust our tests or not. But that's something for a new issue/PR. Let's include the post meta revision enhancement I mentioned on the issue here in this PR as well. We can now also remove the Generally speaking, with the bump to 6.4 we want to see adopt all the new features in 6.4 that are relevant for this plugin. The above are just a few examples that I saw, based on the field guide. |
|
Hi @swissspidy, I have used the The error that appears is: This is thrown in if ( ! empty( $object_subtype ) && ! post_type_supports( $object_subtype, 'revisions' ) ) {
_doing_it_wrong( __FUNCTION__, __( 'Meta keys cannot enable revisions support unless the object subtype supports revisions.' ), '6.4.0' );
}This shouldn't be happening, since we're passing |
|
The issue is that Just had a quick look at it and the reason is surprisingly trivial: The Unfortunately this kind of stuff hasn't really been caught by tests (until now). |
swissspidy
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The goal of the PR is to Bump WordPress minimum to 6.4 in following:
readme.txtweb-stories.phpminimum_supported_wp_versioninphpcs.xml.disttests-e2e.ymlandtests-unit-php.ymlStory_Post_Typeclass, ensurePOSTER_META_KEYandPUBLISHER_LOGO_META_KEYare part of revisionsProduct_Metaclass, ensurePRODUCTS_POST_META_KEYis a part of revisionsUser-facing changes
Not applicable.
Testing Instructions
Not applicable.
Reviews
Does this PR have a security-related impact?
No.
Does this PR change what data or activity we track or use?
No.
Does this PR have a legal-related impact?
No.
Checklist
Type: XYZlabel to the PRFixes #13703