Fix: 🐛 Add Reset button for scheduled stories
#13471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnuragVasanwala
added
Type: Enhancement
swissspidy
reviewed
Oct 3, 2023
Comment on lines
104
to
106
| const floatingDate = | ||
| ['draft', 'pending', 'auto-draft'].includes(status) && | ||
| ['draft', 'pending', 'auto-draft', 'future'].includes(status) && | ||
| (date === modified || date === null); |
There was a problem hiding this comment.
Is this condition ever true for scheduled posts? I think a post with status future will always have a non-null date, and the scheduled date will always be different from the modified date.
In other words, do we need this? Can we revert this change?
There was a problem hiding this comment.
A story will be marked as future whenever we schedule it. Thus, including it solved the issue!
Updating floatingDate will display "Immediate" label and show Reset button.
There was a problem hiding this comment.
Well, I guess if it works it works! :-)
|
Plugin builds for f50d7e2 are ready 🛎️!
|
|
Size Change: +7 B (0%) Total Size: 2.75 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The goal of the PR is to show
Resetbutton for scheduled stories.User-facing changes
With this PR,
Resetbutton will be shown in calendar for the scheduled stories. Clicking on theResetbutton will enable user to publish story immediately.Animated GIF:
Testing Instructions
This PR can be tested by following these steps described in the issue #13428.
Reviews
Does this PR have a security-related impact?
No.
Does this PR change what data or activity we track or use?
No.
Does this PR have a legal-related impact?
No.
Checklist
Type: XYZlabel to the PRFixes #13428