Build java 21 from temurin archives for debian 12 #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mihaimaruseac could use your bazel eyes if you have a chance |
loosebazooka
force-pushed
the
initial-java21
branch
from
5d9358d to
d8a6b9a
Compare
Closed
loosebazooka
commented
Oct 30, 2023
This is "experimental" and we shouldn't advertise it. TODO: 1. auto updater: check github releases for a new version and generate an appropriate java_archives.bzl 2. eventually cover java 11, 17 on debian 12 with temurin 3. ask someone with intimate knowledge of bazel how to get version from the custom repository_rule into the env of the container Signed-off-by: Appu Goundan <[email protected]>
loosebazooka
force-pushed
the
initial-java21
branch
from
d8a6b9a to
6678d3f
Compare
|
@Alos fyi |
Signed-off-by: Appu Goundan <[email protected]>
loosebazooka
force-pushed
the
initial-java21
branch
from
8701ced to
d4fc62a
Compare
|
alright, I think we worked through all the problems. This is ready @bobcallaway. @mihaimaruseac if you would like to officially review it, that would be very helpful. |
bobcallaway
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is "experimental" and we shouldn't advertise it.
TODO: