New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cert without domain #133

Merged

jonchenn merged 2 commits into main from cert-without-domain

Oct 3, 2023

Collaborator

jonchenn commented Oct 3, 2023

Added terraform count to prevent cert deployed without domain
Added a default domain (localhost) in the ingress yaml

jonchenn added 2 commits

October 3, 2023 11:52


          added count to gce ingress to prevent managed cert if no domains

7389e28


          added a default domain as localhost in ingress yaml

271322f

jonchenn requested a review from lavjain

October 3, 2023 03:56

lavjain approved these changes

View reviewed changes

jonchenn merged commit 217d904 into main

lavjain deleted the cert-without-domain branch

October 4, 2023 14:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet