Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow templates registered into other workspace paths #826

Conversation

douglasjacobsen
Copy link
Collaborator

This merge allows workspace path variables to be replaced in destination paths for templates that are registered in objects.

This allows a template to be rendered into the shared directory of a workspace, as an example.

Copy link
Collaborator

@linsword13 linsword13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff! One nit request, but otherwise LGTM.

lib/ramble/ramble/application.py Outdated Show resolved Hide resolved
This commit allows workspace path variables to be replaced in
destination paths for templates that are registered in objects.

This allows a template to be rendered into the shared directory of a
workspace, as an example.
@douglasjacobsen douglasjacobsen force-pushed the templates-path-replacements branch from 745cd47 to 2a6f7e8 Compare January 15, 2025 19:59
@linsword13 linsword13 merged commit 300a8bc into GoogleCloudPlatform:develop Jan 15, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants