chore: add requests and limits to initContainer #972
+26
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids issues with Gatekeeper policies rejecting workloads that do not specify resource requests.
bwplotka
approved these changes
May 16, 2024
| @@ -49,11 +49,11 @@ resources: | |||
| memory: 16M | |||
| bash: | |||
| limits: | |||
| memory: 32M | |||
| memory: 1M | |||
There was a problem hiding this comment.
I hope touch CLI does not use more than 1M.. but it's likely we see occasional OOM here, no? Is it worth a risk?
|
Yea - I may hold off on merging. For some reason E2E tests are timing out with this change... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids issues with Gatekeeper policies rejecting workloads that do not specify resource requests.
Note - the scheduler should not be affected, as the maximum of initContainers and containers is considered the effective request amount.
Also fixes a minor nit where we were setting the wrong container requests from the values file. We rename "collector" values to "prometheus" and fix the incorrect mapping in our helm charts.