chore(operator): remove ensure AM and rule-eval resource #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
force-pushed
the
am-rule-eval-deadcode
branch
from
4de052f to
1876b72
Compare
After security hardening, those serve no purpose at the moment as AFAIK. I also removed watches for those which is not needed. Signed-off-by: bwplotka <[email protected]>
bwplotka
force-pushed
the
am-rule-eval-deadcode
branch
from
1876b72 to
d5ccdd8
Compare
TheSpiritXIII
approved these changes
Sep 24, 2024
| @@ -83,7 +83,7 @@ rules: | |||
| - deployments | |||
| apiGroups: ["apps"] | |||
| resourceNames: ["rule-evaluator"] | |||
| verbs: ["get", "list", "watch"] | |||
| verbs: ["get", "list"] | |||
There was a problem hiding this comment.
I think we should be able to get rid of them all? Any other places/reason we look them up?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After security hardening, those serve no purpose at the moment as AFAIK. I also removed watches for those which is not needed.
I noticed this thanks to
cl/677695994discussion and when I was exploring past regressions in related flows #692