chore: update manifests to 0.13.1 #1147
Conversation
bwplotka
force-pushed
the
images-def
branch
from
5b25ddf to
d770a7b
Compare
bwplotka
changed the title
| bash: | ||
| image: gke.gcr.io/gke-distroless/bash | ||
| tag: "gke_distroless_20240607.00_p0" # NOTE: Has to be quoted otherwise it will be treated as a number. | ||
| tag: "gke_distroless_20240907.00_p0" | ||
| alertmanager: |
There was a problem hiding this comment.
is it possible to update the alertmanager image at this stage of the release or no?
There was a problem hiding this comment.
Not yet, we will do once 0.14.0 is out with manually bumped AM new image.
There was a problem hiding this comment.
However we can follow what @pintohutch suggested and did in 0.13 branch - change things on release/0.14 to what we expect to release once prod images are there, then cherry pick to main once done. Will try that.
|
suggestion: |
First, we preemptively tag the binaries in this repo with their anticipated Docker image tags from the build pipeline. Secondly, we bump the tags of prometheus and alertmanager to match what we expect will be deployed in the final manifest. Signed-off-by: Danny Clark <[email protected]> # Conflicts: # charts/values.global.yaml # cmd/datasource-syncer/datasource-syncer.yaml # manifests/operator.yaml # manifests/rule-evaluator.yaml
bwplotka
force-pushed
the
images-def
branch
from
d770a7b to
0d3d80e
Compare
|
Nice I like your flow started in https://github.com/GoogleCloudPlatform/prometheus-engine/pull/1117/files#diff-812b265e1da8d8a3c64370d7d4b87bd6d109bda0d44b066ee86b8329d4004f43 Cherry-pick + update of distroless here. PTAL @pintohutch @damemi |
Signed-off-by: bwplotka <[email protected]>
bwplotka
force-pushed
the
images-def
branch
from
0d3d80e to
3632172
Compare
|
I am going to merge this. I think we have to simply claim that manifests from main will be not always buildable due to tag lag #1013 (comment) 0.13.1 is good to have here, but due to perms main manifests won't work anyway, proceeding cutting 0.14 release branch to get 0.14 prod images we can cherry pick later to main. |
Cherry pick of https://github.com/GoogleCloudPlatform/prometheus-engine/pull/1117/files#diff-812b265e1da8d8a3c64370d7d4b87bd6d109bda0d44b066ee86b8329d4004f43 and distroless bump.