feat: add config-reloader readiness #1075
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSpiritXIII
force-pushed
the
TheSpiritXIII/config-ready
branch
2 times, most recently
from
6c4038c to
42d972c
Compare
|
Can you fill out the description and describe what this change is doing and the motivation for it? |
TheSpiritXIII
force-pushed
the
TheSpiritXIII/config-ready
branch
from
42d972c to
28e6cf4
Compare
|
@pintohutch I updated the description. Feel free to push back on this change! |
|
@TheSpiritXIII - IIUC our discussion around supporting "empty" mandatory flag/config will make this change unnecessary. Is that your understanding as well? |
|
@pintohutch yes this change becomes non-critical. This PR may still provide a slightly better signal over when a workload is "ready" than we have today, but again, let's not prioritize it unless we need to. |
|
LGTM, but we need to resolve the conflicts. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a readiness endpoint to the config-reloader. This helps Kubernetes be more accurate in accessing that workloads are up.
The primary reason I added it is for #1076 -- I wanted the config-reloader to start running before Prometheus is running. However, the config-reloader must hit a reload URL. As a "hack", I made it hit an endpoint of itself that does nothing. Since this endpoint is functionally the same as a readiness endpoint, I figured we might as well add a few more missing pieces to turn this into a readiness endpoint that Kubernetes can hit. This also helps make the PRs smaller and hopefully easier to review.