Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add PKCS11 automations #7

Merged

Conversation

romanini-ciandt
Copy link
Collaborator

@romanini-ciandt romanini-ciandt commented Apr 17, 2024

The goal of this PR is to introduce all the available PKCS11 and CNG provider automations

@romanini-ciandt romanini-ciandt self-assigned this Apr 17, 2024
@romanini-ciandt romanini-ciandt requested review from tdbhacks and a team as code owners April 17, 2024 13:48
@romanini-ciandt romanini-ciandt marked this pull request as draft April 17, 2024 19:04
Copy link
Member

@tdbhacks tdbhacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know when this is ready for review, I see you are trying to debug the failing test :) quick note in the meantime: let's use "OSS" as the root folder name prefix instead of pkcs11, because we use pkcs11 for the CNG use case just to create the self-signed certificate, but pkcs11 and CNG are unrelated. On the other hand, the apache and nginx samples rely directly on pkcs11, so it's fine to use it in the name there. Thanks!

@romanini-ciandt romanini-ciandt marked this pull request as ready for review April 30, 2024 14:08
@romanini-ciandt
Copy link
Collaborator Author

@tdbhacks changed the root folder name to "OSS". What is "OSS" btw?

FYI: I removed the "examples" for this PR for now because I will need more time to investigate a CI issue - I'll add the examples in a different PR later.

Also, when we merge this PR, let's not forget to mark the squash commit option. I made a lot of tests in this branch.

Copy link
Member

@tdbhacks tdbhacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Leo! Reworded the root README, will merge right after it's updated

oss-terraform-automation/README.md Outdated Show resolved Hide resolved
@tdbhacks
Copy link
Member

tdbhacks commented May 2, 2024

@tdbhacks changed the root folder name to "OSS". What is "OSS" btw?

FYI: I removed the "examples" for this PR for now because I will need more time to investigate a CI issue - I'll add the examples in a different PR later.

Also, when we merge this PR, let's not forget to mark the squash commit option. I made a lot of tests in this branch.

Fair question, sorry :) OSS = open-source software. Punting the examples investigation sounds good to me!

@romanini-ciandt romanini-ciandt requested a review from tdbhacks May 3, 2024 13:46
@tdbhacks tdbhacks merged commit f7efb29 into GoogleCloudPlatform:main May 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants