-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add PKCS11 automations #7
feat: Add PKCS11 automations #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know when this is ready for review, I see you are trying to debug the failing test :) quick note in the meantime: let's use "OSS" as the root folder name prefix instead of pkcs11, because we use pkcs11 for the CNG use case just to create the self-signed certificate, but pkcs11 and CNG are unrelated. On the other hand, the apache and nginx samples rely directly on pkcs11, so it's fine to use it in the name there. Thanks!
…feat/pkcs11-automations
@tdbhacks changed the root folder name to "OSS". What is "OSS" btw? FYI: I removed the "examples" for this PR for now because I will need more time to investigate a CI issue - I'll add the examples in a different PR later. Also, when we merge this PR, let's not forget to mark the squash commit option. I made a lot of tests in this branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Leo! Reworded the root README, will merge right after it's updated
Fair question, sorry :) OSS = open-source software. Punting the examples investigation sounds good to me! |
Co-authored-by: Alessio Buraggina <[email protected]>
The goal of this PR is to introduce all the available PKCS11 and CNG provider automations