-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Include producer example #28
chore: Include producer example #28
Conversation
@@ -0,0 +1 @@ | |||
��5�iu��?HS�E����B�J�xi%Ϙ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this hard-coded sample DEK in order to avoid adding a null resource with openssl rand
command.
(.index
at the end is to avoid errors on lint about whitespace at the end of the file - we can't add a whitespace in DEK)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all LGTM, thanks Leo! It does bring up an interesting conversation in my mind though, which is that we should formalize some sort of breaking change policy for the long term, right? It comes to mind as this change adds new input variables, or for other changes we might make in the future.
It's definitely not a concern now and not blocking this change by any means, this repo is still work-in-progress and we state so clearly in the main README, but more like food for thought. I think TF repos generally have a way of announcing something will change, and later change it in the next major version, right?
@tdbhacks that is an excellent point! I'll make a couple tests/researches in order to understand how exactly how the bot works, but what I know is that bot cut releases based on the PR's names. So if the PR has |
Hi @romanini-ciandt - It is https://github.com/googleapis/release-please, here is a sample config for a pre-1.0 release: https://github.com/terraform-google-modules/terraform-google-module-template/blob/master/terraform-google-%7B%7Bcookiecutter.module_name%7D%7D/.github/release-please.yml |
Great reference @apeabody! Thanks for that! I'll create a PR to introduce the release-please bot into this repo. |
The goal of this PR is to introduce an end-to-end test on sharing data with partner automation by adding a usage example. CI will do the auto discover tests (see the run here).