Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix Go dependencies manually #152

Conversation

romanini-ciandt
Copy link
Collaborator

@romanini-ciandt romanini-ciandt commented Dec 27, 2024

@tdbhacks I manually generated the dependencies in this PR, hopefully it will achieve what's #148 is trying to do

@romanini-ciandt romanini-ciandt marked this pull request as ready for review December 27, 2024 21:49
@apeabody
Copy link
Contributor

@tdbhacks I manually generated the dependencies in this PR, hopefully it will achieve what's #148 is trying to do

Thanks @romanini-ciandt - Yeah, the automated PRs don't always work correctly when there are multiple go.mod.

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for test/integration

@tdbhacks
Copy link
Member

tdbhacks commented Jan 4, 2025

Thanks @romanini-ciandt! :)

@tdbhacks tdbhacks merged commit 41a3bb2 into GoogleCloudPlatform:main Jan 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants