Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[debian] replaced apt-key with more modern approach #576

Conversation

cjac
Copy link

@cjac cjac commented Dec 20, 2024

As requested in GoogleCloudPlatform/ops-agent#1132

Thank you @sbconslt for hounding us to get it done.

@cjac cjac requested a review from a team as a code owner December 20, 2024 06:57
@cjac
Copy link
Author

cjac commented Dec 20, 2024

Come to think of it, I prefer --no-default-keyring --keyring to --dearmor -o since the former can store multiple keys in the file.

@braydonk
Copy link

Since this is just a copy of this script and not the canonical version, I would suggest closing this PR; the correct approach would be to change the actual script and copy it into this repo again.

cjac added 2 commits December 20, 2024 08:05
… GoogleCloudDataproc/initialization-actions/templates/legal/license_header
@cjac
Copy link
Author

cjac commented Dec 20, 2024

@braydonk - oh? This is not the original? Can you tell me where the original lives? I do want to update the file at https://dl.google.com/cloudagents/add-google-cloud-ops-agent-repo.sh and I thought this was what fed that one.

Can you please advise? What file should be modified?

@braydonk
Copy link

@cjac I have sent you a message internally with the source location of the script that is launched to that URL.

@iennae
Copy link
Contributor

iennae commented Dec 20, 2024

@braydonk can you share with me as well as I haven't heard that there is a source

@iennae iennae closed this Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants