-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmarking script v2 #866
Open
Bslabe123
wants to merge
28
commits into
main
Choose a base branch
from
request-rates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bslabe123
requested review from
achandrasekar,
ahg-g,
annapendleton and
jjk-g
as code owners
November 13, 2024 23:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major script refactoring changes:
Backend
class.ttft
prometheus metric added.t
, this applies to the--job
flag discussed below and the--request-rate
flag. A few examples of newly valid inputs:10+(t/60)
, a request rate increasing linearly by 1rps/minmin(40,20+20(floor([t/300](http://t/300))))
, start at 20, step to 40 after 300s, do not step up more--job
flag for multi step benchmarking:--job
has more than one stage, the "metrics" field will not be rendered on the json outputBreaking changes:
---request-rate
no longer has a default valueGiven the size of this PR the following will be added as follow ups:
--job
flag for multi step benchmarking rather than multiple script runsTests:
TEST 1: With these flags to assure no breaking changes to output json:
JSON diff with accepted output and output text file:
TEST 2: With these flags to duplicate the above test using the
--job
flag:where r.json is
output text file:
TEST 3: Multi step benchmarking using
--job
flag:Using the same flags above with the following r.json
Resulting logs:
Resulting output is the following two text files and json:
TEST 4:
Demonstrate the output of
f(t)
request rates using the following r.json, this particular rate should send ~360 requests, with the same flags as above:Result text file: