-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TPU Provisioner: Fix skipped scale ups & garbage collect zombie node pools #277
Merged
danielvegamyhre
merged 10 commits into
GoogleCloudPlatform:main
from
nstogner:tpu-provisioner--fix-scale-up-bug
Mar 19, 2024
Merged
TPU Provisioner: Fix skipped scale ups & garbage collect zombie node pools #277
danielvegamyhre
merged 10 commits into
GoogleCloudPlatform:main
from
nstogner:tpu-provisioner--fix-scale-up-bug
Mar 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstogner
changed the title
TPU Provisioner: Fix skipped scale ups
TPU Provisioner: Fix skipped scale ups & garbage collect zombie node pools
Mar 8, 2024
nstogner
force-pushed
the
tpu-provisioner--fix-scale-up-bug
branch
from
March 12, 2024 01:26
1e51be3
to
1039c27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, left a few minor comments and questions
Updated to address comments. Also made deletion delay configurable to make sure |
…of node pool in stopping state
…low tests to pass
nstogner
force-pushed
the
tpu-provisioner--fix-scale-up-bug
branch
from
March 19, 2024 19:47
b9fdef5
to
72c34c6
Compare
Rebased @danielvegamyhre |
/gcbrun |
danielvegamyhre
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make test
passes consistently.