fix test cases

GoogleCloudPlatform · Mar 8, 2024 · bcb2733 · bcb2733
1 parent e051edd
commit bcb2733
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 4 deletions.
diff --git a/applications/jupyter/workloads-auto-create-brand.example.tfvars b/applications/jupyter/workloads-auto-create-brand.example.tfvars
@@ -17,6 +17,7 @@
 project_id = "<gcp-prj-id>"
 
 ## this is required for terraform to connect to GKE master and deploy workloads
+create_cluster        = false # this flag will create a new standard public gke cluster in default network
 cluster_name          = "<cluster-name>"
 cluster_location      = "us-central1"
 cluster_membership_id = "" # required only for private cluster, default: cluster_name

diff --git a/applications/jupyter/workloads-existing-brand-auto-create-client.example.tfvars b/applications/jupyter/workloads-existing-brand-auto-create-client.example.tfvars
@@ -17,6 +17,7 @@
 project_id = "<gcp-prj-id>"
 
 ## this is required for terraform to connect to GKE master and deploy workloads
+create_cluster        = false # this flag will create a new standard public gke cluster in default network
 cluster_name          = "<cluster-name>"
 cluster_location      = "us-central1"
 cluster_membership_id = "" # required only for private cluster, default: cluster_name

diff --git a/applications/jupyter/workloads-existing-brand-existing-client.example.tfvars b/applications/jupyter/workloads-existing-brand-existing-client.example.tfvars
@@ -17,6 +17,7 @@
 project_id = "<gcp-prj-id>"
 
 ## this is required for terraform to connect to GKE master and deploy workloads
+create_cluster        = false # this flag will create a new standard public gke cluster in default network
 cluster_name          = "<cluster-name>"
 cluster_location      = "us-central1"
 cluster_membership_id = "" # required only for private cluster, default: cluster_name

diff --git a/applications/jupyter/workloads-without-iap.example.tfvars b/applications/jupyter/workloads-without-iap.example.tfvars
@@ -17,6 +17,7 @@
 project_id = "<gcp-prj-id>"
 
 ## this is required for terraform to connect to GKE master and deploy workloads
+create_cluster        = false # this flag will create a new standard public gke cluster in default network
 cluster_name          = "<cluster-name>"
 cluster_location      = "us-central1"
 cluster_membership_id = "" # required only for private clusters, default: cluster_name

diff --git a/applications/jupyter/workloads.tfvars b/applications/jupyter/workloads.tfvars
@@ -17,6 +17,7 @@
 project_id = "<your project ID>"
 
 ## this is required for terraform to connect to GKE master and deploy workloads
+create_cluster        = false # this flag will create a new standard public gke cluster in default network
 cluster_name          = "ml-cluster"
 cluster_location      = "us-central1"
 cluster_membership_id = "" # required for private cluster, defaults to `cluster_name`

diff --git a/applications/ray/workloads.tfvars b/applications/ray/workloads.tfvars
@@ -18,20 +18,19 @@
 project_id = "<your project ID>"
 
 ## this is required for terraform to connect to GKE master and deploy workloads
-cluster_name     = "<your project ID>"
+create_cluster   = false # this flag will create a new standard public gke cluster in default network
+cluster_name     = "<cluster name>"
 cluster_location = "us-central1"
 
 #######################################################
 ####    APPLICATIONS
 #######################################################
 
-## GKE environment variables
-
 ## GKE environment variables
 ray_namespace = "ml"
 
 # Creates a google service account & k8s service account & configures workload identity with appropriate permissions.
-# Set to false & update the variable `gcp_service_account` to use an existing IAM service account.
+# Set to false & update the variable `workload_identity_service_account` to use an existing IAM service account.
 create_service_account            = true
 workload_identity_service_account = "ray-service-account"