Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cassandra Schema and Value Mapping #2048

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

VardhanThigle
Copy link
Contributor

@VardhanThigle VardhanThigle commented Dec 4, 2024

Cassandra Schema and Data mapping for primitive types.

This PR covers mapping of primitive types to Avro for Cassansdra.
As of this PR, all the non-primitive types are mapped to null.

TODOS:

  • spanner writer handling for the 2 new unified types introduced.
  • end to end integration with pipeline options and CassandraIO.
  • integration and lod testsing
  • support for non-primitive types.

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 99.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 53.80%. Comparing base (6a50180) to head (d5eac53).

Files with missing lines Patch % Lines
.../cassandra/mappings/CassandraMappingsProvider.java 97.95% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2048      +/-   ##
============================================
+ Coverage     45.98%   53.80%   +7.82%     
+ Complexity     3810     1456    -2354     
============================================
  Files           851      388     -463     
  Lines         50844    21093   -29751     
  Branches       5359     2114    -3245     
============================================
- Hits          23381    11350   -12031     
+ Misses        25760     9062   -16698     
+ Partials       1703      681    -1022     
Components Coverage Δ
spanner-templates 69.07% <99.33%> (+1.47%) ⬆️
spanner-import-export ∅ <ø> (∅)
spanner-live-forward-migration 76.42% <100.00%> (+0.11%) ⬆️
spanner-live-reverse-replication 77.35% <100.00%> (+0.09%) ⬆️
spanner-bulk-migration 87.17% <99.33%> (+0.29%) ⬆️
Files with missing lines Coverage Δ
...eader/io/cassandra/mappings/CassandraMappings.java 100.00% <100.00%> (ø)
.../cassandra/rowmapper/CassandraSourceRowMapper.java 100.00% <100.00%> (ø)
...rce/reader/io/cassandra/rowmapper/FieldMapper.java 100.00% <100.00%> (ø)
...ource/reader/io/cassandra/rowmapper/RowMapper.java 100.00% <100.00%> (ø)
.../io/cassandra/schema/CassandraSchemaDiscovery.java 98.24% <ø> (ø)
...eader/io/schema/typemapping/UnifiedTypeMapper.java 100.00% <100.00%> (ø)
...ema/typemapping/provider/unified/CustomSchema.java 100.00% <100.00%> (ø)
...pping/provider/unified/UnifiedMappingProvider.java 100.00% <100.00%> (ø)
...er/migrations/avro/GenericRecordTypeConvertor.java 93.58% <100.00%> (+0.46%) ⬆️
.../cassandra/mappings/CassandraMappingsProvider.java 97.95% <97.95%> (ø)

... and 485 files with indirect coverage changes

@VardhanThigle VardhanThigle force-pushed the cassandra-mapping branch 9 times, most recently from 9a82e35 to 3d23485 Compare December 11, 2024 10:03
@VardhanThigle VardhanThigle force-pushed the cassandra-mapping branch 2 times, most recently from 76e2b48 to fb0b666 Compare December 11, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant