tests: Bulk IT Tests #2005
Open
tests: Bulk IT Tests #2005
+1,184
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2005 +/- ##
============================================
+ Coverage 45.40% 52.93% +7.52%
+ Complexity 3672 1367 -2305
============================================
Files 842 378 -464
Lines 49970 20661 -29309
Branches 5261 2090 -3171
============================================
- Hits 22690 10936 -11754
+ Misses 25608 9045 -16563
+ Partials 1672 680 -992
|
Deep1998
reviewed
Nov 19, 2024
| * changes to schema. Changes include Index changes, Primary key transformations and Generated | ||
| * columns migration. | ||
| */ | ||
| @Category({TemplateIntegrationTest.class, SkipDirectRunnerTest.class}) |
There was a problem hiding this comment.
nit: If its meant to test primary key transformations and generated columns and index change specifically, can we modify the name to capture that, maybe advancedSchemaChangesIT or something like that.
with comments mentioning more details like this tests:
- Different indexes
- Different primary key columns
- Generated and Default value columns at Source and Not on Spanner migrated correctly.
THis helps track what sort of cases are covered.
Deep1998
reviewed
Nov 19, 2024
| spannerResourceManager.readTableRecords( | ||
| "employee_attribute", "employee_id", "attribute_name", "value"); | ||
|
|
||
| SpannerAsserts.assertThatStructs(employeeAttribute).hasRows(4); // Supports composite keys |
There was a problem hiding this comment.
Any reason we are not doing full row matches like the first assert?
There was a problem hiding this comment.
+1 add full row asserts wherever possible.
darshan-sj
approved these changes
Nov 25, 2024
| spannerResourceManager.readTableRecords( | ||
| "employee_attribute", "employee_id", "attribute_name", "value"); | ||
|
|
||
| SpannerAsserts.assertThatStructs(employeeAttribute).hasRows(4); // Supports composite keys |
There was a problem hiding this comment.
+1 add full row asserts wherever possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.